domd: use drmkms in non weston build for libsdl2 - #89
Open
arminn wants to merge 3 commits into
Open
Conversation
lorc
approved these changes
Sep 18, 2024
lorc
left a comment
lorc
left a comment
Collaborator
There was a problem hiding this comment.
Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
arminn
force-pushed
the
mr_libsdl2_drmkms
branch
from
September 19, 2024 08:22
65fc94c to
bce7a55
Compare
In most products dom0 used as a control domain and not as backend domain. Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
arminn
force-pushed
the
mr_libsdl2_drmkms
branch
from
September 20, 2024 10:29
bce7a55 to
144fec9
Compare
arminn
force-pushed
the
mr_libsdl2_drmkms
branch
from
October 2, 2024 20:31
144fec9 to
f3d0328
Compare
Contributor
Author
|
testing patches |
arminn
force-pushed
the
mr_libsdl2_drmkms
branch
from
October 3, 2024 11:31
f3d0328 to
a7436bb
Compare
lorc
reviewed
Oct 3, 2024
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| PACKAGECONFIG:append = "${@' kmsdrm gles2 ' if 'wayland' not in d.getVar('DISTRO_FEATURES', True).split() else ''}" | |||
Collaborator
There was a problem hiding this comment.
This is very convoluted way to write ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', '', 'kmsdrm gles2 ', d)} :)
Please rewrite it in Yocto-way
| @@ -0,0 +1,3 @@ | |||
| [Unit] | |||
| Requires=backend-ready@bridge.service | |||
Collaborator
There was a problem hiding this comment.
Are you sure you need this dependency? I believe doma can start right away (i.e. without any additional dependencies) if there is no wayland.
In our configuration, QEMU uses libsdl2 as a backend for display. At the same time, in weston build, libsdl2 uses weston window for display output. In non weston build it is proposed to use drmkms for the display output. Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
Introduce new property XT_DOMD_DISPLAY_SYSTEM, which will hint display system in DomD to chose appropriate domain dependancies for start. I.e. if weston used - we assume that prior guest start, weston should be ready and running to give possibility for gues draw into window. Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
arminn
force-pushed
the
mr_libsdl2_drmkms
branch
from
October 4, 2024 14:36
a7436bb to
64ec206
Compare
Contributor
Author
|
Changed target branch to kirkstone. |
lorc
reviewed
Oct 4, 2024
| # virtio-env-weston.conf whould be used if we have the weston compositor in domd | ||
| # the product should redefine variable. | ||
|
|
||
| XT_DOMD_DISPLAY_SYSTEM ??= "weston" |
Collaborator
There was a problem hiding this comment.
Oh, now you have this in two recipes... I believe it is better to move this variable definition to some common .inc file, to decrease code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our configuration, QEMU uses libsdl2 as a backend for display. At the same time, in weston build, libsdl2 uses weston window for display output. In non weston build it is proposed to use drmkms for the display output.